Unify icon contributions and clarify supported formats#450
Open
brisvag wants to merge 14 commits into
Open
Conversation
willingc
reviewed
Apr 10, 2026
Contributor
willingc
left a comment
willingc
left a comment
There was a problem hiding this comment.
Looks good. Seems to have a circular import that in the tests.
Contributor
Author
|
Since it's not reused, I just moved the validator to the model where it's needed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 2795 2802 +7
=========================================
+ Hits 2795 2802 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Czaki
reviewed
May 13, 2026
| PluginManifest(name="myplugin", icon="my_plugin:myicon.png") | ||
| pm = PluginManifest(name="myplugin", icon="my_plugin:myicon.png") | ||
| assert pm.icon == "my_plugin:myicon.png" | ||
| pm = PluginManifest(name="myplugin", icon="https://example.com/icon.png") |
Collaborator
There was a problem hiding this comment.
I don't think that we should allow remote icons in plugins. This is a big privacy issue.
Member
There was a problem hiding this comment.
Actually, this is a really important point, it let's someone track things, like the 1px by 1px white image in your emails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to unify a bit the manifest regarding icons, and to bring it more in line with what the underlying app-model accepts.
We actually "officially" support more things than appmodel (e.g: https urls), and I'm not sure whether we plan to keep these and handle the extra logic ourselves or what else to do. At least with this we start supporting dark/light for all icon fields.